Conversation
kirill-stupakov
requested changes
Oct 17, 2023
Collaborator
kirill-stupakov
left a comment
kirill-stupakov
left a comment
There was a problem hiding this comment.
Надо бы на Next JS переделать
kirill-stupakov
requested changes
Oct 27, 2023
|
|
||
|
|
||
| const TODO_LIST_ENDPOINT = 'http://localhost:8000/todos/' | ||
| const TODO_LIST_ENDPOINT = 'http://localhost:3000/todos/' |
Collaborator
There was a problem hiding this comment.
Тут надо бы использовать переменные окружения
| const TODO_LIST_ENDPOINT = 'http://localhost:3000/todos/' | ||
|
|
||
|
|
||
| interface item { |
Collaborator
There was a problem hiding this comment.
Типы и интерфейсы принято называть с большой буквы
| completed: boolean; | ||
| } | ||
|
|
||
| export const getServerSideProps: GetServerSideProps<{ todolist: item[] }> = async (context) => { |
Collaborator
There was a problem hiding this comment.
Тут можно использовать TodoProps
| const handleToggle = (id: number) => { | ||
| setTodos( | ||
| todos.map((todo) => { | ||
| todos?.map((todo) => { |
Collaborator
There was a problem hiding this comment.
А todos разве могут быть undefined?
| response => response.json() | ||
| ).then( | ||
| data => setTodos(todos.concat(data)) | ||
| data => setTodos(todos?.concat(data)) |
| }).then(r => { | ||
| if (r.ok) { | ||
| const newTodos = todos.filter(todo => todo.id !== id); | ||
| const newTodos = todos?.filter(todo => todo.id !== id); |
| <h1>Todo List</h1> | ||
| <div className="list"> | ||
| {todos.map((todo) => ( | ||
| {todos?.map((todo) => ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SSR to project